Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return might be non-empty-list/non-empty-array for map functions #384

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Return might be non-empty-list/non-empty-array for map functions #384

merged 1 commit into from
Dec 21, 2022

Conversation

dragosprotung
Copy link
Contributor

If the input is non-empty the return will also be non-empty-*.

iterable is a more generic type, but the conditional return still helps with better understanding the return value in certain scenarios.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3740389551

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.082%

Totals Coverage Status
Change from base Build 3739403627: 0.0%
Covered Lines: 3779
Relevant Lines: 3814

💛 - Coveralls

azjezz
azjezz previously approved these changes Dec 20, 2022
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. labels Dec 20, 2022
@azjezz azjezz added this to the 3.0.0 milestone Dec 20, 2022
@dragosprotung dragosprotung changed the base branch from next to 2.3.x December 20, 2022 16:56
@dragosprotung dragosprotung dismissed azjezz’s stale review December 20, 2022 16:56

The base branch was changed.

@dragosprotung
Copy link
Contributor Author

I targeted by mistake the next branch

@azjezz azjezz merged commit 59509e9 into azjezz:2.3.x Dec 21, 2022
@dragosprotung dragosprotung deleted the fix/return-types branch December 21, 2022 13:26
renovate bot referenced this pull request in ben-challis/sql-migrations Jan 26, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [azjezz/psl](https://github.com/azjezz/psl) | require | minor |
`2.3.1` -> `2.4.1` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>azjezz/psl</summary>

### [`v2.4.1`](https://github.com/azjezz/psl/releases/tag/2.4.1):
Lenalee - 2.4.1

[Compare Source](https://github.com/azjezz/psl/compare/2.4.0...2.4.1)

#### What's Changed

- undeprecate `positive_int()` by
[@&#8203;dragosprotung](https://github.com/dragosprotung) in
[https://github.com/azjezz/psl/pull/400](https://github.com/azjezz/psl/pull/400)

**Full Changelog**: azjezz/psl@2.4.0...2.4.1

### [`v2.4.0`](https://github.com/azjezz/psl/releases/tag/2.4.0):
Lenalee - 2.4.0

[Compare Source](https://github.com/azjezz/psl/compare/2.3.1...2.4.0)

#### What's Changed

##### Features

- Add range function by [@&#8203;azjezz](https://github.com/azjezz) in
[https://github.com/azjezz/psl/pull/385](https://github.com/azjezz/psl/pull/385)
- Add nonnull type by [@&#8203;azjezz](https://github.com/azjezz) in
[https://github.com/azjezz/psl/pull/392](https://github.com/azjezz/psl/pull/392)
- Add uint type by [@&#8203;azjezz](https://github.com/azjezz) in
[https://github.com/azjezz/psl/pull/393](https://github.com/azjezz/psl/pull/393)
- Add signed integer types by
[@&#8203;azjezz](https://github.com/azjezz) in
[https://github.com/azjezz/psl/pull/394](https://github.com/azjezz/psl/pull/394)
- Add unsigned integer types by
[@&#8203;KennedyTedesco](https://github.com/KennedyTedesco) in
[https://github.com/azjezz/psl/pull/395](https://github.com/azjezz/psl/pull/395)
- Add f32 and f64 types by
[@&#8203;KennedyTedesco](https://github.com/KennedyTedesco) in
[https://github.com/azjezz/psl/pull/396](https://github.com/azjezz/psl/pull/396)

##### fixes, and improvements

- Return might be non-empty-list/non-empty-array for map functions by
[@&#8203;dragosprotung](https://github.com/dragosprotung) in
[https://github.com/azjezz/psl/pull/384](https://github.com/azjezz/psl/pull/384)
- Add Async documentation by
[@&#8203;azjezz](https://github.com/azjezz) in
[https://github.com/azjezz/psl/pull/386](https://github.com/azjezz/psl/pull/386)
- remove float ranges by [@&#8203;azjezz](https://github.com/azjezz)
in
[https://github.com/azjezz/psl/pull/391](https://github.com/azjezz/psl/pull/391)
- update changelog by
[@&#8203;KennedyTedesco](https://github.com/KennedyTedesco) in
[https://github.com/azjezz/psl/pull/397](https://github.com/azjezz/psl/pull/397)
- Improve options type declarations and add andThen method by
[@&#8203;veewee](https://github.com/veewee) in
[https://github.com/azjezz/psl/pull/398](https://github.com/azjezz/psl/pull/398)

#### New Contributors

- [@&#8203;KennedyTedesco](https://github.com/KennedyTedesco) made
their first contribution in
[https://github.com/azjezz/psl/pull/395](https://github.com/azjezz/psl/pull/395)

**Full Changelog**: azjezz/psl@2.3.1...2.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ben-challis/sql-migrations).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExMS4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants